feat(spring-webmvc): add Spring Boot 4 / Spring Framework 7 api version support#11587
Closed
wconti27 wants to merge 1 commit into
Closed
feat(spring-webmvc): add Spring Boot 4 / Spring Framework 7 api version support#11587wconti27 wants to merge 1 commit into
wconti27 wants to merge 1 commit into
Conversation
…tDep support Reads `HandlerMapping.API_VERSION_ATTRIBUTE` (added in Spring Framework 7) from the request and records it as the `http.api_version` span tag. Bumps latestDepTestImplementation spring-boot-starter-* pins from 3.+ to 4.+, so CI exercises the implementation against Spring Boot 4 / SF7. Adds SpringWebHttpServerDecoratorApiVersionTest covering present / absent / empty / non-String attribute cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
wconti27
force-pushed
the
conti/feat/spring-webmvc-sb4-api-version
branch
from
15e8714 to
f5083b5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latestDepTestImplementationspring-boot-starter-* to4.+inspring-webmvc-6.0/build.gradleto enable testing against Spring Boot 4 / Spring Framework 7HandlerMapping.apiVersionattribute from the request and sethttp.api_versionspan tag inSpringWebHttpServerDecoratorSpringWebHttpServerDecoratorApiVersionTestvalidating that the api version tag is set when the attribute is presentSpringWebHttpServerDecoratorTestcovering existing decorator behaviourMotivation
Spring Framework 7 (Spring Boot 4) introduces structured API versioning via
HandlerMapping. This change surfaces the resolved API version as a span tag so it is queryable in Datadog APM.Test plan
./gradlew :dd-java-agent:instrumentation:spring:spring-webmvc:spring-webmvc-6.0:compileJava :dd-java-agent:instrumentation:spring:spring-webmvc:spring-webmvc-6.0:compileTestJava— passes./gradlew :dd-java-agent:instrumentation:spring:spring-webmvc:spring-webmvc-6.0:test— unit tests pass./gradlew :dd-java-agent:instrumentation:spring:spring-webmvc:spring-webmvc-6.0:latestDepTest— passes with Spring Boot 4.x🤖 Generated with APM Instrumentation Toolkit